natty
/
misskey-awawa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: provide NoSuchNoteError error

This commit is contained in:
syuilo 2023-09-20 11:43:33 +09:00
parent 5d65e34078
commit fa13b815ef
2 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/backend/src/core/ClipService.ts
View File

@ -143,6 +143,12 @@ export class ClipService {
throw new ClipService.NoSuchClipError(); throw new ClipService.NoSuchClipError();
} }
const note = await this.notesRepository.findOneBy({ id: noteId });
if (note == null) {
throw new ClipService.NoSuchNoteError();
}
await this.clipNotesRepository.delete({ await this.clipNotesRepository.delete({
noteId: noteId, noteId: noteId,
clipId: clip.id, clipId: clip.id,

2
packages/backend/src/server/api/endpoints/clips/remove-note.ts
View File

@ -52,6 +52,8 @@ export default class extends Endpoint<typeof meta, typeof paramDef> { // eslint-
} catch (e) { } catch (e) {
if (e instanceof ClipService.NoSuchClipError) { if (e instanceof ClipService.NoSuchClipError) {
throw new ApiError(meta.errors.noSuchClip); throw new ApiError(meta.errors.noSuchClip);
} else if (e instanceof ClipService.NoSuchNoteError) {
throw new ApiError(meta.errors.noSuchNote);
} }
throw e; throw e;
} }