diff --git a/frontend/src/fileReceiver.js b/frontend/src/fileReceiver.js index d0854e1c..209a9ecd 100644 --- a/frontend/src/fileReceiver.js +++ b/frontend/src/fileReceiver.js @@ -19,9 +19,7 @@ class FileReceiver extends EventEmitter { xhr.onload = function(event) { if (xhr.status === 404) { - reject( - new Error('notfound') - ); + reject(new Error('notfound')); return; } diff --git a/frontend/src/upload.js b/frontend/src/upload.js index 84279760..a65cde85 100644 --- a/frontend/src/upload.js +++ b/frontend/src/upload.js @@ -135,7 +135,7 @@ $(document).ready(function() { event.preventDefault(); // don't allow upload if not on upload page - if ($('#page-one').attr('hidden')){ + if ($('#page-one').attr('hidden')) { return; } @@ -472,7 +472,7 @@ $(document).ready(function() { const $popupNvmSpan = $('', { class: 'popup-no' }); $popupNvmSpan.attr('data-l10n-id', 'deletePopupCancel'); - $popupText.html([$popupMessage, $popupDelSpan, $popupNvmSpan]); + $popupText.html([$popupMessage, $popupDelSpan, $popupNvmSpan]); // add data cells to table row row.appendChild(name); diff --git a/server/server.js b/server/server.js index d3c10203..49fbe7e0 100644 --- a/server/server.js +++ b/server/server.js @@ -47,10 +47,7 @@ app.use( 'https://sentry.prod.mozaws.net', 'https://www.google-analytics.com' ], - imgSrc: [ - "'self'", - 'https://www.google-analytics.com' - ], + imgSrc: ["'self'", 'https://www.google-analytics.com'], scriptSrc: ["'self'"], styleSrc: ["'self'", 'https://code.cdn.mozilla.net'], fontSrc: ["'self'", 'https://code.cdn.mozilla.net'], @@ -116,10 +113,10 @@ app.get('/download/:id', (req, res) => { return; } - storage.filename(id).then(filename => { - storage - .length(id) - .then(contentLength => { + storage + .filename(id) + .then(filename => { + return storage.length(id).then(contentLength => { storage.ttl(id).then(timeToExpiry => { res.render('download', { filename: decodeURIComponent(filename), @@ -128,11 +125,11 @@ app.get('/download/:id', (req, res) => { timeToExpiry: timeToExpiry }); }); - }) - .catch(() => { - res.status(404).render('notfound'); }); - }); + }) + .catch(() => { + res.status(404).render('notfound'); + }); }); app.get('/assets/download/:id', (req, res) => { diff --git a/server/storage.js b/server/storage.js index 66a1a192..93d1c46c 100644 --- a/server/storage.js +++ b/server/storage.js @@ -27,7 +27,6 @@ if (conf.s3_bucket) { length: awsLength, get: awsGet, set: awsSet, - aad: aad, setField: setField, delete: awsDelete, forceDelete: awsForceDelete, @@ -44,7 +43,6 @@ if (conf.s3_bucket) { length: localLength, get: localGet, set: localSet, - aad: aad, setField: setField, delete: localDelete, forceDelete: localForceDelete, @@ -66,11 +64,10 @@ function quit() { function metadata(id) { return new Promise((resolve, reject) => { redis_client.hgetall(id, (err, reply) => { - if (!err) { - resolve(reply); - } else { - reject(err); + if (err || !reply) { + return reject(err); } + resolve(reply); }); }); } @@ -78,11 +75,10 @@ function metadata(id) { function ttl(id) { return new Promise((resolve, reject) => { redis_client.ttl(id, (err, reply) => { - if (!err) { - resolve(reply * 1000); - } else { - reject(err); + if (err || !reply) { + return reject(err); } + resolve(reply * 1000); }); }); } @@ -90,11 +86,10 @@ function ttl(id) { function filename(id) { return new Promise((resolve, reject) => { redis_client.hget(id, 'filename', (err, reply) => { - if (!err) { - resolve(reply); - } else { - reject(err); + if (err || !reply) { + return reject(); } + resolve(reply); }); }); } @@ -115,18 +110,6 @@ function setField(id, key, value) { redis_client.hset(id, key, value); } -function aad(id) { - return new Promise((resolve, reject) => { - redis_client.hget(id, 'aad', (err, reply) => { - if (!err) { - resolve(reply); - } else { - reject(); - } - }); - }); -} - function localLength(id) { return new Promise((resolve, reject) => { try {