From 6231385c74d9fac302a4e17768d339f9155eabd6 Mon Sep 17 00:00:00 2001
From: Abhinav Adduri <abhinadduri@gmail.com>
Date: Tue, 11 Jul 2017 11:18:31 -0700
Subject: [PATCH 1/2] fixed issues in branch title

---
 frontend/src/fileReceiver.js |  2 +-
 server/portal_server.js      | 25 +++++++++++++++++++++++++
 views/download.handlebars    |  4 ++++
 3 files changed, 30 insertions(+), 1 deletion(-)

diff --git a/frontend/src/fileReceiver.js b/frontend/src/fileReceiver.js
index 37924038..241d8aac 100644
--- a/frontend/src/fileReceiver.js
+++ b/frontend/src/fileReceiver.js
@@ -12,7 +12,7 @@ class FileReceiver extends EventEmitter {
         const xhr = new XMLHttpRequest();
 
         xhr.onprogress = event => {
-          if (event.lengthComputable) {
+          if (event.lengthComputable && event.target.status !== 404) {
             const percentComplete = Math.floor(
               event.loaded / event.total * 100
             );
diff --git a/server/portal_server.js b/server/portal_server.js
index c6ed936d..b5f6328b 100644
--- a/server/portal_server.js
+++ b/server/portal_server.js
@@ -45,6 +45,11 @@ app.get('/', (req, res) => {
 
 app.get('/exists/:id', (req, res) => {
   const id = req.params.id;
+  if (!validateID(id)) {
+    res.sendStatus(404);
+    return;
+  }
+
   storage
     .exists(id)
     .then(() => {
@@ -55,6 +60,11 @@ app.get('/exists/:id', (req, res) => {
 
 app.get('/download/:id', (req, res) => {
   const id = req.params.id;
+  if (!validateID(id)) {
+    res.sendStatus(404);
+    return;
+  }
+
   storage.filename(id).then(filename => {
     storage
       .length(id)
@@ -101,10 +111,14 @@ app.get('/assets/download/:id', (req, res) => {
             })
             .catch(err => {
               log.info('DeleteError:', id);
+              res.sendStatus(404);
             });
         });
 
         file_stream.pipe(res);
+      })
+      .catch(err => {
+        res.sendStatus(404);
       });
     })
     .catch(err => {
@@ -124,6 +138,7 @@ app.post('/delete/:id', (req, res) => {
 
   if (!delete_token) {
     res.sendStatus(404);
+    return;
   }
 
   storage
@@ -140,6 +155,12 @@ app.post('/delete/:id', (req, res) => {
 app.post('/upload', (req, res, next) => {
   const newId = crypto.randomBytes(5).toString('hex');
   const meta = JSON.parse(req.header('X-File-Metadata'));
+
+  if (!validateIV(meta.id)) {
+    res.sendStatus(404);
+    return;
+  }
+
   meta.delete = crypto.randomBytes(10).toString('hex');
   log.info('meta', meta);
   req.pipe(req.busboy);
@@ -177,4 +198,8 @@ app.listen(conf.listen_port, () => {
 
 const validateID = route_id => {
   return route_id.match(/^[0-9a-fA-F]{10}$/) !== null;
+};
+
+const validateIV = route_id => {
+  return route_id.match(/^[0-9a-fA-F]{24}$/) !== null;
 };
\ No newline at end of file
diff --git a/views/download.handlebars b/views/download.handlebars
index 41a49da9..ba6cf5c5 100644
--- a/views/download.handlebars
+++ b/views/download.handlebars
@@ -25,8 +25,12 @@
         <div>
           <button id="download-btn" onclick="download()">Download File</button>
         </div>
+        <div id='expired-img'>
+          <img src='/resources/link_expired.png' />
+        </div>
       </div>
 
+
       <div id="download-progress">
         <div  id="download-text">
           Downloading File...

From 8c907c90298f2ad972e21aadb3e1b31fbd3d685d Mon Sep 17 00:00:00 2001
From: Abhinav Adduri <abhinadduri@gmail.com>
Date: Tue, 11 Jul 2017 12:10:11 -0700
Subject: [PATCH 2/2] removed extraneous failure

---
 server/portal_server.js | 1 -
 1 file changed, 1 deletion(-)

diff --git a/server/portal_server.js b/server/portal_server.js
index b5f6328b..dae7e602 100644
--- a/server/portal_server.js
+++ b/server/portal_server.js
@@ -111,7 +111,6 @@ app.get('/assets/download/:id', (req, res) => {
             })
             .catch(err => {
               log.info('DeleteError:', id);
-              res.sendStatus(404);
             });
         });