natty
/
calckey
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: ♻️ correct params for notes/children+conversion

This commit is contained in:
ThatOneCalculator 2023-07-14 23:13:32 -07:00
parent c99480529f
commit c467db2ea2
No known key found for this signature in database
GPG Key ID: 8703CACD01000000
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/backend/src/server/api/endpoints/notes/children.ts
View File

@ -1,4 +1,3 @@
import { Brackets } from "typeorm";
import { Notes } from "@/models/index.js"; import { Notes } from "@/models/index.js";
import define from "../../define.js"; import define from "../../define.js";
import { makePaginationQuery } from "../../common/make-pagination-query.js"; import { makePaginationQuery } from "../../common/make-pagination-query.js";
@ -23,13 +22,14 @@ export const meta = {
ref: "Note", ref: "Note",
}, },
}, },
}; } as const;
export const paramDef = { export const paramDef = {
type: "object", type: "object",
properties: { properties: {
noteId: { type: "string", format: "misskey:id" }, noteId: { type: "string", format: "misskey:id" },
limit: { type: "integer", minimum: 1, maximum: 100, default: 10 }, limit: { type: "integer", minimum: 1, maximum: 100, default: 10 },
depth: { type: "integer", minimum: 1, maximum: 100, default: 12},
sinceId: { type: "string", format: "misskey:id" }, sinceId: { type: "string", format: "misskey:id" },
untilId: { type: "string", format: "misskey:id" }, untilId: { type: "string", format: "misskey:id" },
}, },

4
packages/backend/src/server/api/endpoints/notes/conversation.ts
View File

@ -51,7 +51,7 @@ export default define(meta, paramDef, async (ps, user) => {
const conversation: Note[] = []; const conversation: Note[] = [];
let i = 0; let i = 0;
async function get(id: any) { async function get(id: string) {
i++; i++;
const p = await getNote(id, user).catch((e) => { const p = await getNote(id, user).catch((e) => {
if (e.id === "9725d0ce-ba28-4dde-95a7-2cbb2c15de24") return null; if (e.id === "9725d0ce-ba28-4dde-95a7-2cbb2c15de24") return null;
@ -60,7 +60,7 @@ export default define(meta, paramDef, async (ps, user) => {
if (p == null) return; if (p == null) return;
if (i > ps.offset!) { if (i > ps.offset) {
conversation.push(p); conversation.push(p);
} }