ランダムにテストがコケるのを修正 (#7553)

* Test shutdown

* Revert "Test shutdown"

This reverts commit 85182e7dd1.

* Skip beforeShutdown in test

* Wait shutdown in test

* Revert "Skip beforeShutdown in test"

This reverts commit 79c33ab536.

* Revert "Revert "Skip beforeShutdown in test""

This reverts commit 3423133a13.

src/misc/before-shutdown.ts

@@ -56,6 +56,8 @@ const forceExitAfter = timeout => () => {
  * @param {string} signalOrEvent The exit signal or event name received on the process.
  */
 async function shutdownHandler(signalOrEvent) {
+	if (process.env.NODE_ENV === 'test') return process.exit(0);
+
 	console.warn(`Shutting down: received [${signalOrEvent}] signal`);
 
 	for (const listener of shutdownListeners) {

test/api-visibility.ts

@@ -12,15 +12,15 @@ process.env.NODE_ENV = 'test';
 
 import * as assert from 'assert';
 import * as childProcess from 'child_process';
-import { async, signup, request, post, launchServer } from './utils';
+import { async, signup, request, post, launchServer, shutdownServer } from './utils';
 
 describe('API visibility', () => {
 	let p: childProcess.ChildProcess;
 
 	before(launchServer(g => p = g));
 
-	after(() => {
+	after(async () => {
-		p.kill();
+		await shutdownServer(p);
 	});
 
 	describe('Note visibility', async () => {

test/fetch-resource.ts

@@ -12,7 +12,7 @@ process.env.NODE_ENV = 'test';
 
 import * as assert from 'assert';
 import * as childProcess from 'child_process';
-import { async, launchServer, signup, post, request, simpleGet, port } from './utils';
+import { async, launchServer, signup, post, request, simpleGet, port, shutdownServer } from './utils';
 import * as openapi from '@redocly/openapi-core';
 
 // Request Accept
@@ -39,8 +39,8 @@ describe('Fetch resource', () => {
 		});
 	}));
 
-	after(() => {
+	after(async () => {
-		p.kill();
+		await shutdownServer(p);
 	});
 
 	describe('Common', () => {

test/mute.ts

@@ -12,7 +12,7 @@ process.env.NODE_ENV = 'test';
 
 import * as assert from 'assert';
 import * as childProcess from 'child_process';
-import { async, signup, request, post, react, connectStream, launchServer } from './utils';
+import { async, signup, request, post, react, connectStream, launchServer, shutdownServer } from './utils';
 
 describe('Mute', () => {
 	let p: childProcess.ChildProcess;
@@ -28,8 +28,8 @@ describe('Mute', () => {
 		carol = await signup({ username: 'carol' });
 	}));
 
-	after(() => {
+	after(async () => {
-		p.kill();
+		await shutdownServer(p);
 	});
 
 	it('ミュート作成', async(async () => {

test/note.ts

@@ -12,7 +12,7 @@ process.env.NODE_ENV = 'test';
 
 import * as assert from 'assert';
 import * as childProcess from 'child_process';
-import { async, signup, request, post, uploadFile, launchServer } from './utils';
+import { async, signup, request, post, uploadFile, launchServer, shutdownServer } from './utils';
 import { Note } from '../src/models/entities/note';
 import { initDb } from '../src/db/postgre';
 
@@ -30,8 +30,8 @@ describe('Note', () => {
 		bob = await signup({ username: 'bob' });
 	}));
 
-	after(() => {
+	after(async () => {
-		p.kill();
+		await shutdownServer(p);
 	});
 
 	it('投稿できる', async(async () => {

test/user-notes.ts

@@ -12,7 +12,7 @@ process.env.NODE_ENV = 'test';
 
 import * as assert from 'assert';
 import * as childProcess from 'child_process';
-import { async, signup, request, post, uploadFile, launchServer } from './utils';
+import { async, signup, request, post, uploadFile, launchServer, shutdownServer } from './utils';
 
 describe('users/notes', () => {
 	let p: childProcess.ChildProcess;
@@ -37,8 +37,8 @@ describe('users/notes', () => {
 		});
 	}));
 
-	after(() => {
+	after(async() => {
-		p.kill();
+		await shutdownServer(p);
 	});
 
 	it('ファイルタイプ指定 (jpg)', async(async () => {

test/utils.ts

@@ -5,6 +5,7 @@ const FormData = require('form-data');
 import * as childProcess from 'child_process';
 import * as http from 'http';
 import loadConfig from '../src/config/load';
+import { SIGKILL } from 'constants';
 
 export const port = loadConfig().port;
 
@@ -145,3 +146,19 @@ export function launchServer(callbackSpawnedProcess: (p: childProcess.ChildProce
 		});
 	};
 }
+
+export function shutdownServer(p: childProcess.ChildProcess, timeout = 20 * 1000) {
+	return new Promise((res, rej) => {
+		const t = setTimeout(() => {
+			p.kill(SIGKILL);
+			res('force exit');
+		}, timeout);
+
+		p.once('exit', () => {
+			clearTimeout(t);
+			res('exited');
+		});
+
+		p.kill();
+	});
+}